Skip to content

ci: restore CodeQL code scanning workflow#265

Merged
stormslowly merged 1 commit into
mainfrom
ci/restore-codeql-code-scanning
Jun 2, 2026
Merged

ci: restore CodeQL code scanning workflow#265
stormslowly merged 1 commit into
mainfrom
ci/restore-codeql-code-scanning

Conversation

@stormslowly
Copy link
Copy Markdown
Collaborator

Why

The 13 open code-scanning alerts (actions/missing-workflow-permissions) are stale. Their root cause — workflows not declaring least-privilege GITHUB_TOKEN permissions — was already fixed in #211; every workflow now sets explicit permissions.

They remain open only because GitHub's default code-scanning setup was turned off (default-setup = not-configured), so no analysis has run since 2025-12-31 to re-evaluate and close them.

What

Add an advanced-setup CodeQL workflow scanning actions + javascript-typescript. Once merged, a run on main re-scans the now-hardened workflows, finds 0 actions results, and GitHub auto-closes all 13 stale alerts.

  • The workflow itself follows least privilege: top-level permissions: {} plus narrow per-job grants, so it introduces no new alerts.
  • rust is intentionally omitted to keep CI light (it needs a full project build); it can be added later if wanted.
Code scanning The 13 alerts
Before disabled stuck open (already fixed in code)
After restored (push / PR / weekly) auto-closed on the next main scan

Opened as a draft: the alternative is simply re-enabling GitHub's default setup (no workflow file). Happy to close this in favor of that if preferred.

The GitHub-managed default code scanning setup was turned off
(default-setup = not-configured), so no analysis runs to re-evaluate
alerts. The 13 open 'actions/missing-workflow-permissions' alerts were
already fixed by #211 but stay open with nothing to close them.

Add an advanced-setup CodeQL workflow (actions + javascript-typescript)
so a run on main re-scans the now-hardened workflows and auto-closes the
stale alerts. The workflow itself follows least privilege:
top-level permissions {} plus narrow per-job grants.
@stormslowly stormslowly marked this pull request as ready for review June 2, 2026 03:55
Copilot AI review requested due to automatic review settings June 2, 2026 03:55
@stormslowly stormslowly merged commit 94b9e14 into main Jun 2, 2026
23 checks passed
@stormslowly stormslowly deleted the ci/restore-codeql-code-scanning branch June 2, 2026 03:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores GitHub Code Scanning by adding an “advanced setup” CodeQL workflow so the repository’s workflow-permission alerts can be re-evaluated and auto-closed after a fresh scan on main.

Changes:

  • Adds .github/workflows/codeql.yml to run CodeQL on push/pull_request to main plus a weekly schedule.
  • Configures CodeQL to analyze actions and javascript-typescript with least-privilege permissions and concurrency control.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +23 to +25
analyze:
name: Analyze (${{ matrix.language }})
runs-on: ubuntu-latest
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 2, 2026

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing ci/restore-codeql-code-scanning (90e7b91) with main (fb81a2d)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants