Skip to content

chore: sync renovate config from rspack#240

Merged
stormslowly merged 4 commits into
mainfrom
chore/sync-renovate-config
May 26, 2026
Merged

chore: sync renovate config from rspack#240
stormslowly merged 4 commits into
mainfrom
chore/sync-renovate-config

Conversation

@stormslowly
Copy link
Copy Markdown
Collaborator

@stormslowly stormslowly commented May 25, 2026

What

  • Switch from renovate.json to renovate.json5 to match rspack's format and allow inline comments.
  • Schedule weekly (before 8am Saturday, Asia/Shanghai); restrict managers to github-actions, cargo, npm.
  • Port only rules that apply to this repo: patch crates / napi / patch npm dependencies grouping, mimalloc pin (aligned with rspack's benchmark allocator), disable Node updates, group github-actions with actions/upload-artifact and actions/download-artifact left manual.
  • Skip rspack-only rules (swc/babel/react/playwright/Rspack/@rspack, crate rspack_resolver self-ref, crates/rspack_plugin_css, linting/, lynx-infra/*, rstackjs/rust-cache).

Before / After

Before:

{
  "extends": ["github>Boshen/renovate"],
  "ignorePaths": ["**/node_modules/**", "**/fixtures/**", "benches/**"]
}

After: renovate.json5 extends the rstackjs shared security preset with the project-relevant grouping rules from rspack.

Copilot AI review requested due to automatic review settings May 25, 2026 14:13
@stormslowly stormslowly force-pushed the chore/sync-renovate-config branch from be4d12a to ddcb4bf Compare May 25, 2026 14:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this repository’s Renovate configuration to align with the rstackjs org defaults by switching to a JSON5-based config and adopting the shared security preset plus repo-relevant grouping/manager rules.

Changes:

  • Replace the previous github>Boshen/renovate preset with github>rstackjs/renovate:security plus dependency dashboard + GitHub Actions digest pinning.
  • Move Renovate config to .github/renovate.json5, adding scheduling, manager restrictions, labels, and package grouping rules.
  • Remove the old .github/renovate.json.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/renovate.json5 Adds the new JSON5 Renovate config aligned to rstackjs presets, schedule, enabled managers, and grouping rules.
.github/renovate.json Removes the old Renovate config that extended a personal preset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/renovate.json5
Comment thread .github/renovate.json5
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be4d12abbb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/renovate.json5 Outdated
Comment thread .github/renovate.json5 Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 25, 2026

Merging this PR will degrade performance by 4.57%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 11 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory resolver[multi-thread] 11 MB 11.5 MB -4.57%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chore/sync-renovate-config (92d1db7) with main (9c30323)

Open in CodSpeed

@stormslowly stormslowly reopened this May 25, 2026
Drop github>Boshen/renovate and adopt rstackjs shared security preset plus the
relevant package rules from rspack (cargo/npm/github-actions grouping, mimalloc
pin, manually managed artifact actions, weekly schedule).
@stormslowly stormslowly force-pushed the chore/sync-renovate-config branch from ddcb4bf to bcf2c51 Compare May 25, 2026 14:27
Replace depTypeList / matchPackagePatterns / matchPackagePrefixes /
excludePackage* with the supported matchDepTypes and matchPackageNames
(globs + negation) so each rule actually applies on current Renovate.
Revert an unrelated LICENSE change that slipped into the renovate sync commit.
@stormslowly stormslowly requested a review from chenjiahan May 26, 2026 02:28
@stormslowly stormslowly merged commit 2785393 into main May 26, 2026
20 checks passed
@stormslowly stormslowly deleted the chore/sync-renovate-config branch May 26, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants