Skip to content

perf: compare cached path hash before path #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hardfist wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

perf: compare cached path hash before path #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f51f606
perf: compare cached path hash before path
hardfist May 9, 2026
fa0ba02
perf: compare cache key hash before path
hardfist May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ impl Hash for CachedPath {

impl PartialEq for CachedPath {
fn eq(&self, other: &Self) -> bool {
self.0.path == other.0.path
self.0.hash == other.0.hash && self.0.path == other.0.path
}
}
impl Eq for CachedPath {}
Expand Down Expand Up @@ -390,7 +390,9 @@ impl Hash for dyn CacheKey + '_ {

impl PartialEq for dyn CacheKey + '_ {
fn eq(&self, other: &Self) -> bool {
self.tuple().1 == other.tuple().1
let (self_hash, self_path) = self.tuple();
let (other_hash, other_path) = other.tuple();
self_hash == other_hash && self_path == other_path
}
}

Expand Down
Loading