Skip to content

docs: update http-proxy-middleware migration version#202

Merged
chenjiahan merged 1 commit intomainfrom
chenjiahan/docs-migrate-v1-to-v2
Apr 19, 2026
Merged

docs: update http-proxy-middleware migration version#202
chenjiahan merged 1 commit intomainfrom
chenjiahan/docs-migrate-v1-to-v2

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Apr 19, 2026

Summary

  • fix the v1 -> v2 migration guide to state that http-proxy-middleware was upgraded from v2 to v4, not v3
  • clarify that consumers may encounter breaking changes introduced since v3 during the migration

Related Links

@chenjiahan chenjiahan changed the title docs: correct http-proxy-middleware migration version docs: update http-proxy-middleware migration version Apr 19, 2026
@chenjiahan chenjiahan marked this pull request as ready for review April 19, 2026 08:49
Copilot AI review requested due to automatic review settings April 19, 2026 08:49
@chenjiahan chenjiahan merged commit 42214b2 into main Apr 19, 2026
5 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/docs-migrate-v1-to-v2 branch April 19, 2026 08:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the @rspack/dev-server v1→v2 migration documentation to correctly reflect the http-proxy-middleware major version bump and set expectations about breaking changes during proxy migration.

Changes:

  • Correct the migration guide to state http-proxy-middleware was upgraded to v4 (not v3).
  • Clarify that breaking changes span beyond a single major version during migration (v2→v4).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/migrate-v1-to-v2.md
### Upgraded `http-proxy-middleware` to v4

`http-proxy-middleware` has been updated to v3, which has some breaking changes:
`http-proxy-middleware` has been updated from v2 to v4, with several breaking changes introduced since v3:
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording here is ambiguous/inaccurate: upgrading from v2 to v4 will include breaking changes introduced in v3 and v4, but "introduced since v3" reads like only post-v3 (i.e., v4-only) changes. Consider rephrasing to something like "introduced in v3 and v4" or "introduced since v2" so it matches the upgrade path and the bullet list (which largely reflects the v3 migration).

Suggested change
`http-proxy-middleware` has been updated from v2 to v4, with several breaking changes introduced since v3:
`http-proxy-middleware` has been updated from v2 to v4, with several breaking changes introduced in v3 and v4:

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants