chore: migrate linting to Rslint and Prettier#53
Merged
chenjiahan merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR migrates the project’s linting/formatting setup from Biome to Rslint + Prettier and updates related tooling/configuration to match the rsbuild-plugin-template.
Changes:
- Replace Biome scripts/config with
rslint+prettierscripts and configuration files. - Update git hooks and VS Code recommendations/settings to use Rslint/Prettier tooling.
- Adjust TypeScript loader typings and a test fixture to satisfy new lint rules.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/named-export/src/index.ts | Adjusts fixture code to avoid lint issues by making imports meaningfully used. |
| src/loader.ts | Tightens types around loader callbacks and file handlers (replacing any). |
| rslint.config.ts | Adds Rslint configuration (recommended TS rules). |
| package.json | Updates lint scripts/hooks and swaps devDependencies from Biome to Rslint/Prettier. |
| biome.json | Removes Biome configuration. |
| README.md | Normalizes string quoting to match formatter conventions. |
| .vscode/settings.json | Switches default formatter to Prettier. |
| .vscode/extensions.json | Recommends Rslint + Prettier extensions instead of Biome. |
| .prettierrc | Adds Prettier config (single quotes). |
| .prettierignore | Ignores build artifacts and lockfile from Prettier runs. |
| .github/workflows/test.yml | Normalizes YAML quoting. |
| .github/workflows/release.yml | Normalizes YAML quoting. |
| .github/renovate.json5 | Normalizes Renovate config style/quoting (JSON5). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces Biome with Rslint and Prettier to align linting and formatting with rsbuild-plugin-template. It updates the lint scripts, pre-commit hook, VS Code recommendations/settings, and lockfile, and adjusts small code/test fixture issues required by Rslint recommended rules.