Skip to content

chore: migrate linting to Rslint and Prettier#53

Merged
chenjiahan merged 1 commit intomainfrom
chenjiahan/chore-rslint-prettier
Apr 28, 2026
Merged

chore: migrate linting to Rslint and Prettier#53
chenjiahan merged 1 commit intomainfrom
chenjiahan/chore-rslint-prettier

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

This PR replaces Biome with Rslint and Prettier to align linting and formatting with rsbuild-plugin-template. It updates the lint scripts, pre-commit hook, VS Code recommendations/settings, and lockfile, and adjusts small code/test fixture issues required by Rslint recommended rules.

Copilot AI review requested due to automatic review settings April 28, 2026 09:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR migrates the project’s linting/formatting setup from Biome to Rslint + Prettier and updates related tooling/configuration to match the rsbuild-plugin-template.

Changes:

  • Replace Biome scripts/config with rslint + prettier scripts and configuration files.
  • Update git hooks and VS Code recommendations/settings to use Rslint/Prettier tooling.
  • Adjust TypeScript loader typings and a test fixture to satisfy new lint rules.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/named-export/src/index.ts Adjusts fixture code to avoid lint issues by making imports meaningfully used.
src/loader.ts Tightens types around loader callbacks and file handlers (replacing any).
rslint.config.ts Adds Rslint configuration (recommended TS rules).
package.json Updates lint scripts/hooks and swaps devDependencies from Biome to Rslint/Prettier.
biome.json Removes Biome configuration.
README.md Normalizes string quoting to match formatter conventions.
.vscode/settings.json Switches default formatter to Prettier.
.vscode/extensions.json Recommends Rslint + Prettier extensions instead of Biome.
.prettierrc Adds Prettier config (single quotes).
.prettierignore Ignores build artifacts and lockfile from Prettier runs.
.github/workflows/test.yml Normalizes YAML quoting.
.github/workflows/release.yml Normalizes YAML quoting.
.github/renovate.json5 Normalizes Renovate config style/quoting (JSON5).
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread package.json
Comment thread src/loader.ts
@chenjiahan chenjiahan merged commit 195f263 into main Apr 28, 2026
7 of 9 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/chore-rslint-prettier branch April 28, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants