Skip to content

chore: migrate linting to Rslint and Prettier#29

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/migrate-rslint-prettier
May 7, 2026
Merged

chore: migrate linting to Rslint and Prettier#29
chenjiahan merged 1 commit into
mainfrom
chenjiahan/migrate-rslint-prettier

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

This PR migrates linting and formatting from Biome to Rslint and Prettier so this package matches the current Rstack template tooling. It adds Rslint and Prettier configuration, updates lint scripts and VS Code recommendations, removes Biome, and refreshes formatting output.

Copilot AI review requested due to automatic review settings May 7, 2026 11:03
@chenjiahan chenjiahan merged commit 90606ba into main May 7, 2026
7 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/migrate-rslint-prettier branch May 7, 2026 11:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates this package’s linting/formatting toolchain from Biome to Rslint + Prettier to align with the current Rstack template tooling.

Changes:

  • Remove Biome configuration/usage and add Rslint + Prettier configuration.
  • Update package.json scripts and VS Code recommendations/settings for the new tooling.
  • Apply formatting updates across a few files (e.g., workflow YAML quoting, import formatting).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/dict.ts Formatting-only update to JSON import attributes.
rslint.config.ts Adds the new Rslint configuration entrypoint.
package.json Replaces Biome scripts with rslint + prettier, updates pre-commit hook command, adds new devDependencies.
pnpm-lock.yaml Removes Biome packages and locks new Rslint + Prettier dependencies.
biome.json Removes Biome configuration.
.vscode/settings.json Switches default formatter to Prettier.
.vscode/extensions.json Recommends Rslint + Prettier VS Code extensions.
.prettierrc Adds Prettier configuration (single quotes).
.prettierignore Adds ignores for dist and pnpm-lock.yaml.
.github/workflows/test.yml Formatting-only quoting change.
.github/workflows/release.yml Formatting-only quoting change.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rslint.config.ts
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9475232a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rslint.config.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants