Ensure minimal number of GraphArrayView invalidation calls#300
Draft
cmalinmayor wants to merge 4 commits into
Draft
Ensure minimal number of GraphArrayView invalidation calls#300cmalinmayor wants to merge 4 commits into
cmalinmayor wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, GraphArrayView invalidates the old and new bboxes in the cache any time any node attribute is updated, including totally unrelated ones.
Also, it appears that SQLGraph emits the signal that triggers this twice:
tracksdata/src/tracksdata/graph/_sql_graph.py
Lines 2110 to 2111 in 13f9ba8
tracksdata/src/tracksdata/graph/_sql_graph.py
Lines 2119 to 2120 in 13f9ba8
Every cache invalidation is expensive, and re-invaliding the same area multiple times resets any progress already made in loading.
This PR ensures the following behavior for all graph backends: