Improve web accessibility for theme base16 comments - #1952
Open
designbymimmi wants to merge 1 commit into
Open
Conversation
Increase color vs background color contrast to make it easier to read comments.
Contributor
|
This is really nice. I personally find most dark themes unusable due to comments being so dark they are almost unreadable. Luckily it's usually a simple config change to increase the contrast of comments. But dang, we shouldn't have these defaults :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Increase color vs background color contrast in
base16theme to make it easier to read comments.Screenshots using theme base16.dark
#505050#858585Web accessibility test results
Considerations
Tried to keep the comment color as "dark" as possible to keep it inline with the style of the theme while still improving the accessibility.