Use Absolute names for type hints#258
Conversation
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
|
Pulls: #258 |
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
|
Pulls: #258 |
|
Pulls: #258 |
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
@InvincibleRMC windows CI is still failing though... 👁️
|
I see a lot of the same failures in the last Windows release nightly: https://ci.ros2.org/view/nightly/job/nightly_win_rel/3763/#showFailuresLink |
|
I checked and every single Windows test failure is in the Windows release nightly, and none of them seem really related to this PR. So I'll merge this. |
|
Apparently, I'm late to the party. I'd just like to confirm that the most important behavior that resulted in wrong generated interfaces seems indeed fixed by this PR. There are still a few leftovers that pollute local namespaces, but they're not as important as those polluting the global namespace. Thanks! |
Description
Should address the biggest problem of #257.
In the future I agree everything should be absolute but, for now makes the type hints introduced in #206 absolute to avoid global pollution.
Fixes # (issue)
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information