Add regression test for unread subscription readiness across waits#282
Open
nvcyc wants to merge 1 commit into
Open
Add regression test for unread subscription readiness across waits#282nvcyc wants to merge 1 commit into
nvcyc wants to merge 1 commit into
Conversation
Signed-off-by: CY Chen <cyc@nvidia.com>
nvcyc
marked this pull request as ready for review
July 15, 2026 00:47
|
Tick the box to add this pull request to the merge queue (same as
|
Author
|
Pulls: ros2/rmw_fastrtps#900, #282 |
nvcyc
requested review from
MiguelCompany,
ahcorde,
hidmic,
karsten-nvidia and
yuanknv
July 16, 2026 22:30
MiguelCompany
approved these changes
Jul 17, 2026
fujitatomoya
approved these changes
Jul 17, 2026
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
lgtm with green CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a cross-RMW regression test verifying that a subscription with an unread sample remains ready across repeated rmw_wait() calls.
The test does the following:
This reproduces the case where an executor observes a ready subscription but does not immediately take its sample, such as when a mutually exclusive callback group is temporarily unavailable.
Is this user-facing behavior change?
No. This PR adds a new test case.
Did you use Generative AI?
Yes. OpenAI GPT-5.6 was used to draft the changes in this PR.
Additional Information
This is to test the case fixed in ros2/rmw_fastrtps#900