Skip to content

Add test for possible race in guard condition notification (2)#281

Open
jmachowinski wants to merge 6 commits into
rollingfrom
jm/add_test_for_guard_conditions_race
Open

Add test for possible race in guard condition notification (2)#281
jmachowinski wants to merge 6 commits into
rollingfrom
jm/add_test_for_guard_conditions_race

Conversation

@jmachowinski

@jmachowinski jmachowinski commented Jul 10, 2026

Copy link
Copy Markdown

Description

Same as #280

I can't push to the source repos and therefore opened this PR to iterate faster on the windows CI failure.

MiguelCompany and others added 2 commits July 8, 2026 12:41
@MiguelCompany
Add test for possible race in guard condition notification.
98dc421 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
fix(rmw_destroy_wait_set): Wait for thread to finsh and run multiple …
aed50c2 
…times

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
@jmachowinski

jmachowinski commented Jul 10, 2026

Copy link
Copy Markdown
Author

Pulls: #281, ros2/rmw_fastrtps#895
Gist: https://gist.githubusercontent.com/jmachowinski/e73cca6a332608b286a2a14b31a13010/raw/13be0d5cec704199c3c2d78115ee1ad2d76165d8/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19816

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mergify

mergify Bot commented Jul 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@jmachowinski jmachowinski mentioned this pull request Jul 10, 2026
Open
@fujitatomoya

fujitatomoya commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

@jmachowinski this closes #280?

@jmachowinski

jmachowinski commented Jul 10, 2026

Copy link
Copy Markdown
Author

No, this is just a tmp thing that allows me to use CI without manually setting up a GIST etc. Might be better way to do this....

@fujitatomoya

fujitatomoya commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

looks like CI warnings are unrelated...

@MiguelCompany
Apply changes from review.
8a7a777 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
wjwwood
wjwwood approved these changes Jul 16, 2026
View reviewed changes

@wjwwood wjwwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small comments, but lgtm

Comment thread test_rmw_implementation/test/test_wait_set.cpp Outdated
Comment thread test_rmw_implementation/test/test_wait_set.cpp
Comment thread test_rmw_implementation/test/test_wait_set.cpp Outdated
Janosch Machowinski added 2 commits July 17, 2026 14:39
fix: added missing header
8b35d75 
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
chore: Comments from review
0939731 
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
@jmachowinski
jmachowinski force-pushed the jm/add_test_for_guard_conditions_race branch from 5460bfc to 0939731 Compare July 17, 2026 12:49
@jmachowinski

jmachowinski commented Jul 17, 2026

Copy link
Copy Markdown
Author

Pulls: #281, ros2/rmw_fastrtps#895
Gist: https://gist.githubusercontent.com/jmachowinski/864e939dc53d56fcce13715ad11d45c4/raw/13be0d5cec704199c3c2d78115ee1ad2d76165d8/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19889

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fix: Fix timeout in collect phase
d85401d 
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
@jmachowinski

jmachowinski commented Jul 17, 2026

Copy link
Copy Markdown
Author

Pulls: #281, ros2/rmw_fastrtps#895
Gist: https://gist.githubusercontent.com/jmachowinski/ed5e2b1be5e3aa69820e965bbad137c5/raw/13be0d5cec704199c3c2d78115ee1ad2d76165d8/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19898

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmachowinski @fujitatomoya @wjwwood @MiguelCompany