Include CPP20 and related changes#228
Open
ahcorde wants to merge 1 commit into
Open
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
asymingt
reviewed
Jun 26, 2026
asymingt
left a comment
asymingt
left a comment
There was a problem hiding this comment.
Happy in general with the change. Just one question about c++ standard srtting with ament_cmake_ros_core.
| PUBLIC ${console_bridge_INCLUDE_DIRS}) | ||
| target_link_libraries(${PROJECT_NAME} ${console_bridge_LIBRARIES}) | ||
| # Standalone (non-ament) build: request C++20 for our own translation units. | ||
| target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_20) |
There was a problem hiding this comment.
Should we not be using something from ament_cmake_ros_core here in stead of a hard-coded cxx_std_20. I am asking because it seems to me that the purpose of ament_cmake_ros_core is to abstract away from specific standards, so they my be universally set in a central location.
Contributor
Author
There was a problem hiding this comment.
This is for the case where we are not using ament
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@asymingt FYI