'guia' matches the chapter name; also link it - #1032
Open
maurolepore wants to merge 2 commits into
Open
Conversation
This change responds to feedback from one of our champions, who found the word 'directrices' unclear. To make it clear I propose to a) link the chapter we refer to and b) reword 'directrices' to 'guia' to match the wording of the chapter title. I'm not 100% sure the link is the one we intend. Note I did not add the equivalent link to other templates. Happy to do it if this seems like a useful change.
maurolepore
marked this pull request as ready for review
August 11, 2026 21:07
yabellini
approved these changes
Aug 12, 2026
yabellini
left a comment
yabellini
left a comment
Member
There was a problem hiding this comment.
I like the change. Thanks, @bastianolea, for the feedback.
yabellini
reviewed
Aug 12, 2026
| - [ ] **Desempeño:** Se confirmaron todas las afirmaciones de desempeño. | ||
| - [ ] **Pruebas automáticas:** Hay *tests* unitarios que cubren las funciones esenciales dentro del paquete con un rango razonable de entradas y condiciones. Todas las pruebas corren correctamente en la computadora local. | ||
| - [ ] **Directrices de empaquetado:** El paquete cumple las directrices de empaquetado de rOpenSci. | ||
| - [ ] **Directrices de empaquetado:** El paquete cumple la [guía de empaquetado de rOpenSci](https://devdevguide.netlify.app/es/pkg_building.es). |
Member
There was a problem hiding this comment.
The link should be relative? Only /es/pkg_building.es
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change responds to feedback from one of our champions, who
found the word 'directrices' unclear. To make it clear I propose
to a) link the chapter we refer to and b) reword 'directrices' to
'guia' to match the wording of the chapter title.
I'm not 100% sure the link is the one we intend.
Note I did not add the equivalent link to other templates. Happy to
do it if this seems like a useful change.
Checklist for dev guide maintainers, do not delete 😸