[6.40] Fix DrawImage in TGX11 and TGWin32 - #23154
Open
linev wants to merge 2 commits into
Open
Conversation
If image larger than 50000 dots, loop may went over allocated memory and may overwrite it.
Prevent loop going over allocated memory Only relevant for large images - over 50000 pixels
bellenot
approved these changes
Aug 26, 2026
Test Results 22 files 22 suites 3d 10h 8m 13s ⏱️ For more details on these failures, see this check. Results for commit 279c78c. |
linev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loops allow to access memory outside of allocated array range
Two similar methods on TGX11 and TGWin32
In master this code will be completely changed by #23128 - where problem was recognized