[build] Do not strip away symbols from libraries and executables#22917
Open
dpiparo wants to merge 1 commit into
Open
[build] Do not strip away symbols from libraries and executables#22917dpiparo wants to merge 1 commit into
dpiparo wants to merge 1 commit into
Conversation
By default, scikit-build triggers the stripping of debugging and other symbols, in order to optimize for space. However, the stripping is too aggressive on macOS. This has undesired effects. For example, also the rootcling symbol `usedToIdentifyRootClingByDlSym` is stripped. Its presence changes the behaviour of some routines some ROOT libraries, e.g. when generating dictionaries.
Test Results 23 files 23 suites 3d 15h 38m 48s ⏱️ Results for commit 1695340. |
Contributor
|
Very nice! this fixed the tests that relied on ACLiC with the experimental macOs wheels, except for python 3.14 ... |
dpiparo
marked this pull request as ready for review
July 26, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, scikit-build triggers the stripping of debugging and other symbols, in order to optimize for space.
However, the stripping is too aggressive on macOS. This has undesired effects. For example, also the rootcling symbol
usedToIdentifyRootClingByDlSymis stripped. Its presence changes the behaviour of some routines some ROOT libraries, e.g. when generating dictionaries.