[ntuple] Address some RNTupleProcessor performance bottlenecks#22593
Open
enirolf wants to merge 3 commits into
Open
[ntuple] Address some RNTupleProcessor performance bottlenecks#22593enirolf wants to merge 3 commits into
enirolf wants to merge 3 commits into
Conversation
vepadulano
approved these changes
Jun 12, 2026
Comment on lines
+358
to
+362
| std::size_t currProcessorNumber = fCurrentProcessorNumber; | ||
| ROOT::NTupleSize_t entriesSeen = 0; | ||
| for (unsigned i = 0; i < currProcessorNumber; ++i) { | ||
| entriesSeen += fInnerProcessors[i]->GetNEntries(); | ||
| } |
Member
There was a problem hiding this comment.
Not for this PR, but in principle we could have a cache vector of number of entries per processor which is filled lazily at discovery time whenever a processor needs to connect to file(s)
Contributor
Author
There was a problem hiding this comment.
Actually this is exactly what is done a few lines down and somehow didn't think to do it here, so thanks for pointing this out :D. Let me quickly add it here as well.
enirolf
force-pushed
the
ntuple-proc-chain-bottleneck
branch
from
be1986b to
0c7ea38
Compare
enirolf
force-pushed
the
ntuple-proc-chain-bottleneck
branch
from
724d342 to
d7d839b
Compare
Test Results 21 files 21 suites 3d 5h 44m 41s ⏱️ Results for commit d7d839b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents the unnecessary re-connection of inner RNTuples in a chain upon calling
LoadEntry, by first checking whether the requested entry is before or after the currently loaded entry.In addition, some unnecessary calls to
InitializeandConnectinRNTupleSingleProcessor::GetNEntrieshave been factored out.