[interpreter] Set LLVM_DIR for builtin_llvm#22544
Conversation
This allows using the variable to find a system-installed LLVM with builtin_llvm=OFF.
ferdymercury
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix.
Unrelated: Wouldn't it be cleaner to define a variable rather than hardcoding in two places the 1 ?
Test Results 22 files 22 suites 3d 16h 43m 43s ⏱️ For more details on these failures, see this check. Results for commit 051effd. ♻️ This comment has been updated with latest results. |
Maybe. Or actually we can live with any minor version, a release x.2.p would signify an ABI-breaking change compared to x.1.0 which is usually not permitted, but we don't really care about. But is you say, it's unrelated and not relevant to this PR so I resolved the conversations. |
This allows using the variable to find a system-installed LLVM with
builtin_llvm=OFF.