Skip to content

[interpreter] Set LLVM_DIR for builtin_llvm#22544

Open
hahnjo wants to merge 1 commit into
root-project:masterfrom
hahnjo:llvm-dir
Open

[interpreter] Set LLVM_DIR for builtin_llvm#22544
hahnjo wants to merge 1 commit into
root-project:masterfrom
hahnjo:llvm-dir

Conversation

@hahnjo

@hahnjo hahnjo commented Jun 9, 2026

Copy link
Copy Markdown
Member

This allows using the variable to find a system-installed LLVM with builtin_llvm=OFF.

This allows using the variable to find a system-installed LLVM with
builtin_llvm=OFF.

@ferdymercury ferdymercury left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix.

Unrelated: Wouldn't it be cleaner to define a variable rather than hardcoding in two places the 1 ?

Comment thread interpreter/CMakeLists.txt
Comment thread interpreter/CMakeLists.txt
Comment thread interpreter/CMakeLists.txt
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 16h 43m 43s ⏱️
 3 861 tests  3 851 ✅   0 💤 10 ❌
76 285 runs  76 040 ✅ 235 💤 10 ❌

For more details on these failures, see this check.

Results for commit 051effd.

♻️ This comment has been updated with latest results.

@hahnjo

hahnjo commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

Unrelated: Wouldn't it be cleaner to define a variable rather than hardcoding in two places the 1 ?

Maybe. Or actually we can live with any minor version, a release x.2.p would signify an ABI-breaking change compared to x.1.0 which is usually not permitted, but we don't really care about. But is you say, it's unrelated and not relevant to this PR so I resolved the conversations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR in:Build System

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants