Skip to content

[HS3] Bugfixes to HS3 histfactoy_dist handling#22283

Open
Phmonski wants to merge 1 commit into
root-project:masterfrom
Phmonski:HS3patch
Open

[HS3] Bugfixes to HS3 histfactoy_dist handling#22283
Phmonski wants to merge 1 commit into
root-project:masterfrom
Phmonski:HS3patch

Conversation

@Phmonski

Copy link
Copy Markdown
Contributor

This Pull request:

Patch to HS3 histfacory import and export:

  • added a default error for normsys modifier
  • changes the calculation of data.errors.
  • the generic RooGaussian streamer function exported named RooConstVars as RooRealVars with isConstant(True). Changed the behavior to export RooConstVars as literals.

Changes or fixes:

  • Histfactory normsys modifier get a default value of 0.0
  • Previously, Histfactory used "constrain_p->getX()" to calculate the `erel for export. This resulted in issues when global observables changed in between loading and exporting the Workspace.
  • Added a RooGaussianStreamer class that discriminates between RooRealVars and RooConstVars at export.

Checklist:

  • tested changes locally

@cburgard @will-cern

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 11h 0m 14s ⏱️
 3 863 tests  3 863 ✅ 0 💤 0 ❌
72 810 runs  72 810 ✅ 0 💤 0 ❌

Results for commit ba1ca31.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants