Open
Conversation
jblomer
requested review from
dpiparo,
ferdymercury,
hahnjo,
pcanal and
silverweed
and removed request for
bellenot,
dpiparo,
ferdymercury,
hahnjo and
pcanal
pcanal
reviewed
Apr 23, 2026
Test Results 22 files 22 suites 3d 15h 14m 18s ⏱️ For more details on these failures, see this check. Results for commit ec0de0a. ♻️ This comment has been updated with latest results. |
Member
|
Impressive PR: thanks for it. It should be backported until 6.36. |
silverweed
reviewed
Apr 24, 2026
vepadulano
approved these changes
Apr 24, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM, let's wait for the CI. Just a minor consideration.
chrisburr
reviewed
Apr 24, 2026
jblomer
force-pushed
the
fix-uuid
branch
2 times, most recently
from
bad1286 to
e92b612
Compare
pcanal
reviewed
Apr 24, 2026
pcanal
reviewed
Apr 24, 2026
pcanal
reviewed
Apr 24, 2026
Use UUIDv4 in TDirectory (hence in TDirectoryFile and TFile) and in the RMiniFile. Note that TDirectory is used without gSystem (needed for GetCryptoRandom()) in the context of rootcling. In principle, GetCryptoRandom() should work without a TSystem object. That may be for a later commit. The UUIDv4, unlike the current UUIDv1, is (with high enough probability) globally unique.
Factor out calling the OS crypto random number generator into a free function in the Base package. In turn, TSystem::GetCryptoRandom() can be static and does not rely in gSystem being initialized.
Contributor
Author
|
/backport to 6.40,6.38,6.36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use UUIDv4 in TDirectory (hence in TDirectoryFile and TFile) and in the RMiniFile. Note that TDirectory is used without gSystem (needed for GetCryptoRandom()) in the context of rootcling. In principle, GetCryptoRandom() should work without a TSystem object. That may be for a later PR.
The UUIDv4, unlike the current UUIDv1, is (with high enough probability) globally unique.
Also fixes a race in TUUID::AsString().
EDIT: The last two commits factor out the
GetCryptoRandom()into a free function, so that it can be used unconditionally in the I/O.Fixes #22015
Replaces #22016