JSROOT tests for types/{set,map} - #89
Merged
Merged
Conversation
undefined-panda
force-pushed
the
jsroot-set-map
branch
from
August 10, 2026 10:16
3c951a2 to
69d7efa
Compare
hahnjo
reviewed
Aug 10, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
You may need to sort also the "ordered" containers because that's a guarantee on the reading side when using C++, but I'm not sure ordered containers exist in JavaScript...
undefined-panda
force-pushed
the
jsroot-set-map
branch
2 times, most recently
from
August 10, 2026 15:22
d6b7f9f to
4a89a46
Compare
hahnjo
reviewed
Aug 11, 2026
Member
There was a problem hiding this comment.
You may need to sort also the "ordered" containers because that's a guarantee on the reading side when using C++, but I'm not sure ordered containers exist in JavaScript...
☝️
(and maybe at that point, it may make sense to refactor common functionality to jsroot_reader.mjs...)
undefined-panda
force-pushed
the
jsroot-set-map
branch
2 times, most recently
from
August 11, 2026 08:32
2a5f54a to
28e3d02
Compare
hahnjo
reviewed
Aug 11, 2026
hahnjo
left a comment
hahnjo
left a comment
Member
There was a problem hiding this comment.
Some more comments inline. Can you also add the (ordered) multiset and multimap? They should hopefully work the same...
undefined-panda
force-pushed
the
jsroot-set-map
branch
from
August 12, 2026 08:55
28e3d02 to
801bda3
Compare
hahnjo
reviewed
Aug 12, 2026
undefined-panda
force-pushed
the
jsroot-set-map
branch
from
August 12, 2026 12:02
65803aa to
59d167a
Compare
undefined-panda
force-pushed
the
jsroot-set-map
branch
from
August 12, 2026 12:05
59d167a to
498202e
Compare
hahnjo
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JSROOT read scripts for:
types/settypes/multisettypes/unordered_settypes/unordered_multisettypes/maptypes/multimaptypes/unordered_maptypes/unordered_multimapThis PR adds the necessary read files that use JSROOT to read the binary files generated by the
write.Cfiles in the corresponding ROOT tests.