feat: Ctrl+Click on a slider in the inspector resets value to default - #73
feat: Ctrl+Click on a slider in the inspector resets value to default#73PlkMarudny wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughCtrl/Cmd-clicking an inspector slider now resets its property to the default and clears its keyframes. Shared reset logic handles label and slider interactions. Documentation and asset tests describe and verify the updated shortcut. ChangesInspector reset interaction
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Inspector
participant applyInspectorReset
participant SelectedClip
participant InspectorView
Inspector->>Inspector: Capture Ctrl/Cmd pointerdown on range input
Inspector->>applyInspectorReset: Reset slider property
applyInspectorReset->>SelectedClip: resetPropChannel
applyInspectorReset->>SelectedClip: Save updated clip state
applyInspectorReset->>InspectorView: Re-render inspector
Merge Risk: ⚪ Minimal · up to Ctrl/Cmd-clicking an inspector slider now resets the property to its default and clears keyframes. The change is ready to merge with no known production-impacting risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
In the inspector, Ctrl+Click resets a slider's value to default.
Type of change
How was it verified?
npm testpasses (CI runs it on Node 18 / 20 / 22)test/if this touches the MCP surface, the REST API, or the SVG libraryCLAUDE.md/README.mdif the schema, props, or API changedChecklist
Summary by CodeRabbit
New Features
Documentation
Tests