fix tag detection in linked worktrees - #467
Open
druckdev wants to merge 1 commit into
Open
Conversation
Previously, tags were not detected when they were checked out in a separate linked worktree. This occurred because gitstatus tried to read from `refs/tags` relative to the worktree-specific `.git` directory. However, since tags are shared refs, `refs/tags` will never exist there, but rather in the global git-dir (see the "REFS" section in git-worktree(1)). To fix this, remove the `worktrees/*` suffix from the repository path when needed.
druckdev
force-pushed
the
pr467-tags-in-worktrees
branch
from
August 6, 2025 12:47
eb5e8d9 to
a7f654e
Compare
aauren
added a commit
to aauren/gitstatus
that referenced
this pull request
Sep 10, 2026
Tags are shared refs, so in a linked worktree both refs/tags/ and packed-refs live in the common gitdir rather than the per-worktree .git/worktrees/<name>/ that git_repository_path() returns. Since gitstatusd was reading from the latter, VCS_STATUS_TAG was always empty in a linked worktree even when HEAD sat exactly on a tag. This is PR romkatv#467 by druckdev, but using git_repository_commondir() instead of stripping the worktrees/* suffix by hand, so it also works for submodules whose gitdir doesn't end in .git. The fixture covers a loose tag and a packed tag checked out in linked worktrees, plus the main worktree as a control. see: romkatv#467
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, tags were not detected when they were checked out in a separate linked worktree. This occurred because gitstatus tried to read from
refs/tagsrelative to the worktree-specific.gitdirectory. However, since tags are shared refs,refs/tagswill never exist there, but rather in the global git-dir (see the "REFS" section in git-worktree(1)).To fix this, remove the
worktrees/*suffix from the repository path when needed.To reproduce this issue: