Skip to content

fix(alias): insert string alias replacements literally #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btea wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(alias): insert string alias replacements literally #2029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/alias/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,13 @@ export default function alias(options: RollupAliasOptions = {}): Plugin {
return null;
}

const updatedId = importee.replace(matchedEntry.find, matchedEntry.replacement);
// When "find" is a string, the replacement must be inserted literally.
// Passing it as the second argument of String.replace would interpret
// "$$", "$&" etc. as special replacement patterns.
const updatedId =
typeof matchedEntry.find === 'string'
? importee.replace(matchedEntry.find, () => matchedEntry.replacement)
: importee.replace(matchedEntry.find, matchedEntry.replacement);

if (matchedEntry.resolverFunction) {
return matchedEntry.resolverFunction.call(this, updatedId, importer, resolveOptions);
Expand Down
17 changes: 17 additions & 0 deletions packages/alias/test/alias.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,23 @@ describe('plugin-alias', () => {
]);
});

it('Replaces string aliases literally', async () => {
const result = await resolveAliasWithRollup(
{
entries: [
{ find: 'id', replacement: '$$' },
{ find: 'at', replacement: '$&co' }
]
},
['$$', '$&co'],
[
{ source: 'id', importer: '/src/importer.js' },
{ source: 'at', importer: '/src/importer.js' }
]
);
expect(result).toEqual(['$$', '$&co']);
});

it('Will not confuse modules with similar names', async () => {
const result = await resolveAliasWithRollup(
{
Expand Down
Loading