Skip to content

Add experimental Apple Silicon macOS RC path - #13

Merged
rodgons merged 5 commits into
devfrom
issue-11-macos-release
Jul 31, 2026
Merged

Add experimental Apple Silicon macOS RC path#13
rodgons merged 5 commits into
devfrom
issue-11-macos-release

Conversation

@rodgons

@rodgons rodgons commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • integrate the Apple Silicon SimpleGraphic runtime into the agreed macOS app bundle layout
  • add external-update policy and macOS shortcut/path compatibility
  • package, verify, checksum, and smoke-test zipped macOS RC artifacts
  • publish gated macos-* experimental prereleases without invoking Windows installer automation

Validation

  • 410 Lua tests pass
  • focused macOS policy/build-list tests pass
  • ModCache regeneration is clean
  • real arm64 app build, native closure/signature checks, archive extraction, SimpleGraphic acceptance smoke, and Path of Building initialization smoke pass on Apple Silicon
  • two-axis standards/spec review found no remaining actionable issue

Implements #10 and #11. Prerequisite for exact artifact validation in #12.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rodgons, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fae377ef-d970-4a8f-a261-0471dcb76f23

📥 Commits

Reviewing files that changed from the base of the PR and between 40e1a3f and 13fb508.

📒 Files selected for processing (20)
  • .github/workflows/installer.yml
  • .github/workflows/macos-release.yml
  • .gitignore
  • macos/Info.plist.in
  • macos/README.md
  • macos/build-app.sh
  • macos/launcher.c
  • macos/package-release.sh
  • macos/verify-app.sh
  • spec/System/TestBuildListHelpers_spec.lua
  • spec/System/TestUpdatePolicy_spec.lua
  • src/Classes/ItemsTab.lua
  • src/Classes/NotesTab.lua
  • src/Classes/PassiveTreeView.lua
  • src/Classes/SkillsTab.lua
  • src/Classes/TradeQuery.lua
  • src/Launch.lua
  • src/Modules/Build.lua
  • src/Modules/BuildListHelpers.lua
  • src/Modules/Main.lua
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-11-macos-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rodgons
rodgons merged commit ad4a9be into dev Jul 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant