Api improvements

[0xfornax]

No description provided.

[github-actions]

Coverage Report

[github-actions]

Merging this branch will increase overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service	0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config	0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool/api/response	5.50% (+5.50%)	👍
github.com/rocket-pool/smartnode/rocketpool/node	0.72% (+0.30%)	👍
github.com/rocket-pool/smartnode/shared/services/apitoken	0.80% (+0.80%)	👍
github.com/rocket-pool/smartnode/shared/services/config	3.79% (+0.81%)	👍
github.com/rocket-pool/smartnode/shared/services/config/migration	2.35% (+2.35%)	👍
github.com/rocket-pool/smartnode/shared/services/rocketpool	0.00% (ø)
github.com/rocket-pool/smartnode/shared/types/config	5.45% (+2.09%)	👍

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-api.go	0.00% (ø)	496 (+496)	0	496 (+496)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-home.go	0.00% (ø)	2124 (+41)	0	2124 (+41)
github.com/rocket-pool/smartnode/rocketpool-cli/service/config/settings-native-home.go	0.00% (ø)	1933 (+47)	0	1933 (+47)
github.com/rocket-pool/smartnode/rocketpool-cli/service/service.go	0.00% (ø)	20630 (+44)	0	20630 (+44)
github.com/rocket-pool/smartnode/rocketpool/api/response/response.go	5.50% (+5.50%)	981 (+140)	54 (+54)	927 (+86)	👍
github.com/rocket-pool/smartnode/rocketpool/node/http.go	4.77% (+4.77%)	1885 (+1315)	90 (+90)	1795 (+1225)	👍
github.com/rocket-pool/smartnode/rocketpool/node/sensitive.go	8.26% (+8.26%)	363 (+363)	30 (+30)	333 (+333)	👍
github.com/rocket-pool/smartnode/shared/services/apitoken/token.go	0.80% (+0.80%)	1743 (+1743)	14 (+14)	1729 (+1729)	👍
github.com/rocket-pool/smartnode/shared/services/config/api-config.go	8.25% (+8.25%)	206 (+206)	17 (+17)	189 (+189)	👍
github.com/rocket-pool/smartnode/shared/services/config/migration/migration-manager.go	6.15% (+6.15%)	1236 (+70)	76 (+76)	1160 (-6)	👍
github.com/rocket-pool/smartnode/shared/services/config/migration/v1210-manager.go	7.55% (+7.55%)	318 (+318)	24 (+24)	294 (+294)	👍
github.com/rocket-pool/smartnode/shared/services/config/rocket-pool-config.go	2.14% (+0.57%)	15106 (+803)	323 (+99)	14783 (+704)	👍
github.com/rocket-pool/smartnode/shared/services/config/smartnode-config.go	0.96% (+0.17%)	2292	22 (+4)	2270 (-4)	👍
github.com/rocket-pool/smartnode/shared/services/rocketpool/client.go	0.00% (ø)	15570 (+397)	0	15570 (+397)
github.com/rocket-pool/smartnode/shared/types/config/parameter.go	3.73% (+1.23%)	1530 (+88)	57 (+21)	1473 (+67)	👍
github.com/rocket-pool/smartnode/shared/types/config/port-modes.go	11.42% (+7.09%)	254 (-23)	29 (+17)	225 (-40)	👍
github.com/rocket-pool/smartnode/shared/types/config/types.go	21.74% (+4.35%)	69	15 (+3)	54 (-3)	👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

• github.com/rocket-pool/smartnode/rocketpool/node/http_test.go
• github.com/rocket-pool/smartnode/rocketpool/node/sensitive_test.go
• github.com/rocket-pool/smartnode/shared/services/config/api-config_test.go