Merged
Conversation
darkgnotic
approved these changes
Apr 8, 2026
darkgnotic
left a comment
darkgnotic
left a comment
There was a problem hiding this comment.
Thank you!
I'm curious that we have to do this since it looks like the main better-sqlite3 repo has it already:
Is it just that this is relatively new to better-sqlite3 and we forked from it before that?
I mention this in case an easier or better option would be to pull new changes from upstream.
Contributor
Author
|
I removed load-extension when we forked. I think because it was giving me build errors at the time and we didn't need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.