fix: drop host bind mount from sibling-services so Clone-in-Volume works#2
Open
arv wants to merge 2 commits into
Open
fix: drop host bind mount from sibling-services so Clone-in-Volume works#2arv wants to merge 2 commits into
arv wants to merge 2 commits into
Conversation
Grant contents: write so devcontainers/action can create the template_<id>_<version> tags automatically instead of failing with a warning. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bumps sibling-services to 1.1.0. "Clone Repository in Container Volume" mounts the cloned repo volume at /workspaces; a ..:/workspaces/<app> host bind breaks that flow on a machine with no host checkout (mounts denied), and Dev Containers tooling does not inject a workspace mount for Compose configs. Rely on the injected volume and document Clone-in-Volume as the entry point. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
..:/workspaces/<app>:cachedhost bind from thesibling-servicestemplate'sdevservice and bumps it to 1.1.0. Documents "Clone Repository in Container Volume…" as the entry point (README + NOTES).Why
On a machine with only Docker + VS Code (no host git checkout), Clone-in-Volume is the only way in — and the host bind breaks it:
Clone-in-Volume puts the repo in a Docker volume mounted at
/workspaces. For Compose dev containers the tooling does not inject a workspace mount in the local-folder case, so the bind in the compose file is the only conflict. Dropping it makes the bare-machine flow work; the tradeoff is that the source lives in the repo volume (edited through VS Code) rather than on the host filesystem.Same fix already applied to rocicorp/mono#6120 and rocicorp/hello-zero#62, verified by replicating the Clone-in-Volume end state: workspace boots, sees the repo, no Docker inside, reaches Postgres siblings by service name.
🤖 Generated with Claude Code