Arv/agents gh 1password#8
Open
arv wants to merge 4 commits into
Open
Conversation
…edentials (v2.0.0) Replace the host-side devcontainer-gh-config volume (which persisted a long-lived GitHub token indefinitely) with on-demand token injection from 1Password: - Drop the devcontainer-gh-config mount and its chown; Claude config volume stays persisted. - Bundle the 1Password CLI (op) in install.sh. - Add a ghTokenSecretRef option; a /etc/profile.d snippet resolves GH_TOKEN from the 1Password secret reference fresh per shell (no host persistence). No-op when unset/unauthenticated, falling back to gh auth login / GITHUB_TOKEN. - Update README and tests; bump feature to v2.0.0 (removes gh persistence).
Runs 'devcontainer features test' on pull requests and pushes so the agents feature (codex/claude/gh/op + gh-token profile script) is verified in CI, with no local tooling required. Pins actions/checkout to a commit SHA per org policy.
Clarify the non-obvious bits from real setup: 1Password desktop integration doesn't cross the container boundary, so document two patterns — Pattern A (local: resolve on host, forward GITHUB_TOKEN via remoteEnv; recommended) and Pattern B (headless: in-container op read via ghTokenSecretRef + service account) — including the op-install/.zshrc/GUI-launch gotchas.
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Copilot stopped work on behalf of
arv due to an error
June 15, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.