Detect-and-bail guard for the join_order heuristic in cyclic join queries - #23
Open
jianhongshi123 wants to merge 3 commits into
Open
jianhongshi123 wants to merge 3 commits into
jianhongshi123 wants to merge 3 commits into
Conversation
JP-Reddy
reviewed
Aug 26, 2026
| map<ColKey, ColKey> uf_parent; | ||
| auto all_nodes = BuildPhysicalPlanDAG(plan.get(), uf_parent); | ||
|
|
||
| if (ExistCycle(all_nodes)) { |
Collaborator
There was a problem hiding this comment.
can we do this in an earlier stage, while computing edges or DAG creation perhaps?
Contributor
Author
There was a problem hiding this comment.
The cycle dectection mechanism now relies on the DAG creation, so moving it to the end of DAG creation won't impact the control flow much. However, putting it at computing edges might be possible and might need a different cycle detection mechanism, should I try that?
Collaborator
There was a problem hiding this comment.
yes we want to bail out as early as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cyclic join graphs can produce equivalence classes that
LogicalCreateFilter::CreatePlancan't fully resolve, causing an out-of-bounds access inbound_column_indicesat sink time.This PR adds a detect-and-bail guard for the
join_orderheuristic. When a cyclic join graph is detected, the optimizer skips predicate transfer and returns the original plan.