Flip roots independently in disconnected DAG components - #21
Merged
Merged
Conversation
JP-Reddy
reviewed
Aug 27, 2026
| } | ||
| }; | ||
|
|
||
| struct Component { |
Collaborator
There was a problem hiding this comment.
can you use a more specific name?
JP-Reddy
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Join edges are currently created only for
COMPARE_EQUALconditions. As a result, no edge is created for theDELIM_JOINconditions, which can leave the transfer DAG disconnected. With a single global anchor, roots in components that do not contain the anchor can be flipped indefinitely.This PR assigns an anchor to each connected component and flips its roots independently.