fix(cli): scope 'image search -p' to the project#486
Open
digaobarbosa wants to merge 2 commits into
Open
Conversation
The -p/--project flag was silently ignored: _handle_search passed the project nowhere, so every search returned workspace-wide results. The search/v1 endpoint only honors a project filter expressed inside the RoboQL query (project:<slug>, which the API resolves to a project id) — body-level project/dataset params are ignored. Prepend project:<slug> to the user's query with a leading space (implicit AND) so it stays compatible with free-text/semantic queries; an explicit 'AND (...)' wrapper 500s on free text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
roboflow image search "<query>" -p <project>silently ignored-pand returned workspace-wide results — so IDs could come from other projects, and a follow-upimage get -p <project> <id>would 404.Root cause:
_handle_searchbuilt its args withproject=...but never used it — it calledrfapi.workspace_searchwith only the raw query, so nothing scoped the result to the project.image search"*" -p penguin-finder"class:penguin" -p penguin-finderType of change
How has this change been tested?
test_searchto assert the scoped queryproject:proj tag:test; addedtest_search_without_project_is_unscoped. Full suite passes (python -m unittest),ruff check/formatclean.Will the change affect Universe?
No.
Any specific deployment considerations
N/A (Python SDK / CLI package).
Docs