Skip to content

feature: add centrifugo api and temporal service connect packages#21

Open
rustatian wants to merge 1 commit into
masterfrom
feature/centrifugo-temporal-connect
Open

feature: add centrifugo api and temporal service connect packages#21
rustatian wants to merge 1 commit into
masterfrom
feature/centrifugo-temporal-connect

Conversation

@rustatian

@rustatian rustatian commented Jun 10, 2026

Copy link
Copy Markdown
Member
  • generate Connect-RPC package for the existing CentrifugoApi service (centrifugo/api/v1/apiV1connect) — the connect codegen exclusion now covers only centrifugo/proxy (Centrifugo-facing, stays classic gRPC); the existing api_grpc.pb.go/proxy_grpc.pb.go stubs are regenerated unchanged
  • generate the new temporal.v1.TemporalService (temporal/v1/temporalV1connect) from feature: add temporal control-plane connect service api#75
  • centrifugo generated Go packages are renamed v1apiV1/proxyV1 (full go_package paths, required by connect codegen); all known consumers import them aliased, and the wire format is untouched

merge order: merge this PR before roadrunner-server/api#75 — the update-proto automation dispatched by the api merge regenerates with this Makefile (idempotent on top of the pre-generated files here) and moves the proto/api submodule pointer to api master

Copilot AI review requested due to automatic review settings June 10, 2026 20:39
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rustatian, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 52 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 118141b5-8505-434a-b66f-71d977e08b07

📥 Commits

Reviewing files that changed from the base of the PR and between ead8bee and 09df899.

⛔ Files ignored due to path filters (6)
  • centrifugo/api/v1/api.pb.go is excluded by !**/*.pb.go
  • centrifugo/api/v1/api_grpc.pb.go is excluded by !**/*.pb.go
  • centrifugo/proxy/v1/proxy.pb.go is excluded by !**/*.pb.go
  • centrifugo/proxy/v1/proxy_grpc.pb.go is excluded by !**/*.pb.go
  • temporal/v1/service.pb.go is excluded by !**/*.pb.go
  • temporal/v1/service_grpc.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (4)
  • Makefile
  • centrifugo/api/v1/apiV1connect/api.connect.go
  • proto/api
  • temporal/v1/temporalV1connect/service.connect.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/centrifugo-temporal-connect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Connect-RPC client/server stubs for existing Centrifugo API and a new Temporal service, and updates protobuf Go package names to support Connect codegen while keeping existing gRPC stubs in place.

Changes:

  • Generated Connect-RPC packages for CentrifugoApi (centrifugo/api/v1/apiV1connect) and temporal.v1.TemporalService (temporal/v1/temporalV1connect).
  • Regenerated protobuf Go code and updated Centrifugo package names from v1 to apiV1 / proxyV1 (gRPC stubs remain present).
  • Updated Makefile Connect codegen exclusion to exclude only centrifugo/proxy.

Reviewed changes

Copilot reviewed 2 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
temporal/v1/temporalV1connect/service.connect.go New generated Connect-RPC client/handler for temporal.v1.TemporalService.
temporal/v1/service.pb.go New generated protobuf messages + file descriptor for Temporal service.
temporal/v1/service_grpc.pb.go New generated gRPC client/server stubs for Temporal service.
Makefile Adjusts Connect codegen exclusion to only skip centrifugo/proxy.
centrifugo/proxy/v1/proxy.pb.go Updates generated Go package name to proxyV1 (go_package path change).
centrifugo/proxy/v1/proxy_grpc.pb.go Updates generated Go package name to proxyV1 in gRPC stubs.
centrifugo/api/v1/apiV1connect/api.connect.go New generated Connect-RPC client/handler for CentrifugoApi.
centrifugo/api/v1/api.pb.go Updates generated Go package name to apiV1 (go_package path change).
centrifugo/api/v1/api_grpc.pb.go Updates generated Go package name to apiV1 in gRPC stubs.
Files not reviewed (8)
  • centrifugo/api/v1/api.pb.go: Language not supported
  • centrifugo/api/v1/apiV1connect/api.connect.go: Language not supported
  • centrifugo/api/v1/api_grpc.pb.go: Language not supported
  • centrifugo/proxy/v1/proxy.pb.go: Language not supported
  • centrifugo/proxy/v1/proxy_grpc.pb.go: Language not supported
  • temporal/v1/service.pb.go: Language not supported
  • temporal/v1/service_grpc.pb.go: Language not supported
  • temporal/v1/temporalV1connect/service.connect.go: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants