feature: add centrifugo api and temporal service connect packages#21
feature: add centrifugo api and temporal service connect packages#21rustatian wants to merge 1 commit into
Conversation
|
Warning Review limit reached
More reviews will be available in 30 minutes and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds Connect-RPC client/server stubs for existing Centrifugo API and a new Temporal service, and updates protobuf Go package names to support Connect codegen while keeping existing gRPC stubs in place.
Changes:
- Generated Connect-RPC packages for
CentrifugoApi(centrifugo/api/v1/apiV1connect) andtemporal.v1.TemporalService(temporal/v1/temporalV1connect). - Regenerated protobuf Go code and updated Centrifugo package names from
v1toapiV1/proxyV1(gRPC stubs remain present). - Updated
MakefileConnect codegen exclusion to exclude onlycentrifugo/proxy.
Reviewed changes
Copilot reviewed 2 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| temporal/v1/temporalV1connect/service.connect.go | New generated Connect-RPC client/handler for temporal.v1.TemporalService. |
| temporal/v1/service.pb.go | New generated protobuf messages + file descriptor for Temporal service. |
| temporal/v1/service_grpc.pb.go | New generated gRPC client/server stubs for Temporal service. |
| Makefile | Adjusts Connect codegen exclusion to only skip centrifugo/proxy. |
| centrifugo/proxy/v1/proxy.pb.go | Updates generated Go package name to proxyV1 (go_package path change). |
| centrifugo/proxy/v1/proxy_grpc.pb.go | Updates generated Go package name to proxyV1 in gRPC stubs. |
| centrifugo/api/v1/apiV1connect/api.connect.go | New generated Connect-RPC client/handler for CentrifugoApi. |
| centrifugo/api/v1/api.pb.go | Updates generated Go package name to apiV1 (go_package path change). |
| centrifugo/api/v1/api_grpc.pb.go | Updates generated Go package name to apiV1 in gRPC stubs. |
Files not reviewed (8)
- centrifugo/api/v1/api.pb.go: Language not supported
- centrifugo/api/v1/apiV1connect/api.connect.go: Language not supported
- centrifugo/api/v1/api_grpc.pb.go: Language not supported
- centrifugo/proxy/v1/proxy.pb.go: Language not supported
- centrifugo/proxy/v1/proxy_grpc.pb.go: Language not supported
- temporal/v1/service.pb.go: Language not supported
- temporal/v1/service_grpc.pb.go: Language not supported
- temporal/v1/temporalV1connect/service.connect.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CentrifugoApiservice (centrifugo/api/v1/apiV1connect) — the connect codegen exclusion now covers onlycentrifugo/proxy(Centrifugo-facing, stays classic gRPC); the existingapi_grpc.pb.go/proxy_grpc.pb.gostubs are regenerated unchangedtemporal.v1.TemporalService(temporal/v1/temporalV1connect) from feature: add temporal control-plane connect service api#75v1→apiV1/proxyV1(fullgo_packagepaths, required by connect codegen); all known consumers import them aliased, and the wire format is untouchedmerge order: merge this PR before roadrunner-server/api#75 — the update-proto automation dispatched by the api merge regenerates with this Makefile (idempotent on top of the pre-generated files here) and moves the
proto/apisubmodule pointer to api master