Update hasNoDataSoRefersToExisting logic - #4275
Open
scharron wants to merge 1 commit into
Open
Conversation
Same as rnmapbox#4205 (comment) RNMBXRasterArraySource now uses tileUrlTemplates instead of uRL, and therefore it should check it contains data to render.
scharron
requested a deployment
to
CI with Mapbox Tokens
August 4, 2026 20:21 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
scharron
requested a deployment
to
CI with Mapbox Tokens
August 4, 2026 20:21 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
scharron
requested a deployment
to
CI with Mapbox Tokens
August 4, 2026 20:21 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Android Mapbox v11-compat implementation of RNMBXRasterArraySource so the “no data, therefore this must refer to an existing source” heuristic accounts for the newer tileUrlTemplates-based configuration (in addition to the legacy uRL property). This aligns RNMBXRasterArraySource behavior with the existing RNMBXRasterSource/RNMBXRasterDemSource logic and prevents raster array sources from being incorrectly treated as “existing” when they actually have template data to render.
Changes:
- Update
RNMBXRasterArraySource.hasNoDataSoRefersToExisting()to considertileUrlTemplates.isEmpty()alongsideuRL == null.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #4205 (comment) RNMBXRasterArraySource now uses tileUrlTemplates instead of uRL, and therefore it should check it contains data to render.
Description
Fixes #
Added
your featurethat allows ...Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing