Fix ie11 - #36
Conversation
|
|
||
| target.head.appendChild(newStyleEl) | ||
| const newStyleEl = target.createElement('style') | ||
| newStyleEl.contentText = ruleText.join('\n') |
There was a problem hiding this comment.
Should it be textContent instead of contentText?
There was a problem hiding this comment.
I pulled down your PR, and it should be textContent indeed`
|
|
||
| target.head.appendChild(newStyleEl) | ||
| const newStyleEl = target.createElement('style') | ||
| newStyleEl.contentText = ruleText.join('\n') |
There was a problem hiding this comment.
I pulled down your PR, and it should be textContent indeed`
|
Is this project still active? I need the ie11 support. |
|
I believe at the very least this need a rebase to the latest version. (I'll do it later, also some fix for reviewer's comment) |
|
Hello all! Im sorry for being silent in this project. This weekend I will
check out all issues and prs and process them.
…On Fri, Oct 2, 2020, 07:38 Wei-Cheng Pan ***@***.***> wrote:
I believe at the very least this need a rebase to the latest version.
(I'll do it later, also some fix for reviewer's comment)
Also #19 <#19> is still
not merged, not sure if I should just include that diff or not.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADLMH2S6FGCU4RQ4LZXW2TSIW3U7ANCNFSM4HFOIUCQ>
.
|
|
@legnaleurc you can include it if you want. |
|
Whatever you decide, let me know, then I will merge your changes. |
1. IE11 cannot access cssText for keyframes rules 2. performance problem in IE11
|
Done. Although this solves problems for IE11, I believe there are some bugs in Edge(non-Edgeium one) while using |
|
Thank you @legnaleurc! I will take a look soon at it. |
|
I'm still hoping this can be fixed at some point. |
6 participants
NOTE this PR depends on #19, please merge it first.
Summary:
IE11 cannot access
CSSRule.cssTextfor keyframes rules.it is not
undefined, it just throwPermission Deniederror.So we need to reassemble it.
IE11 has very bad performance for
HTMLElement.appendChild, so I replace them to simple string.Use DocumentFragment to avoid unnecessary reflow.