Skip to content

Fix creating new window does not work in Edge #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanewtaylor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix creating new window does not work in Edge #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/NewWindow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class NewWindow extends React.PureComponent {
*/
constructor(props) {
super(props)
this.container = document.createElement('div')
this.container = null
this.window = null
this.windowCheckerInterval = null
this.released = false
Expand Down Expand Up @@ -97,7 +97,7 @@ class NewWindow extends React.PureComponent {

// Open a new window.
this.window = window.open(url, name, toWindowFeatures(features))

this.container = this.window.document.createElement('div')
// When a new window use content from a cross-origin there's no way we can attach event
// to it. Therefore, we need to detect in a interval when the new window was destroyed
// or was closed.
Expand Down Expand Up @@ -194,7 +194,7 @@ function copyStyles(source, target) {
console.error(err)
}
if (rules) {
const newStyleEl = source.createElement('style')
const newStyleEl = target.createElement('style')

// Write the text of each rule into the body of the style element
Array.from(styleSheet.cssRules).forEach(cssRule => {
Expand All @@ -215,13 +215,13 @@ function copyStyles(source, target) {
})
.join('url(')
}
newStyleEl.appendChild(source.createTextNode(returnText))
newStyleEl.appendChild(target.createTextNode(returnText))
})

target.head.appendChild(newStyleEl)
} else if (styleSheet.href) {
// for <link> elements loading CSS from a URL
const newLinkEl = source.createElement('link')
const newLinkEl = target.createElement('link')

newLinkEl.rel = 'stylesheet'
newLinkEl.href = styleSheet.href
Expand Down