Skip to content

fix(workflows): reject divergent root history - #8

Open
WyvernMonarch wants to merge 1 commit into
rivet-dev:mainfrom
WyvernMonarch:fix/root-step-history-divergence
Open

fix(workflows): reject divergent root history#8
WyvernMonarch wants to merge 1 commit into
rivet-dev:mainfrom
WyvernMonarch:fix/root-step-history-divergence

Conversation

@WyvernMonarch

Copy link
Copy Markdown

Summary

  • validate the root workflow context before committing a completed result
  • reject a renamed root step before registering or executing it when persisted history still contains an unvisited entry
  • fail history divergence without replaying rollback against incompatible workflow code
  • preserve removed(..., "message") migrations by marking generated message-history entries as visited

Testing

  • pnpm run ci
  • regression coverage in both yield and live modes verifies that a renamed root step throws HistoryDivergedError without mutating persisted history

@WyvernMonarch

Copy link
Copy Markdown
Author

used workflows in my work, had an issue that required upstream changes, cause I had my stuff crashing cause of it

big fan of rivet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant