Merged
Conversation
bgentry
force-pushed
the
bg/delete-confirm-dialog
branch
from
7533063 to
5380d88
Compare
bgentry
changed the title
Deleting jobs is irreversible, but the UI previously dispatched both the single-job and bulk delete actions immediately. That made it too easy to remove the wrong jobs with one stray click, especially from the bulk selection toolbar. Add a shared confirmation dialog built on the existing Headless UI `Dialog` primitives and route only delete actions through it. The job detail page now confirms before deleting one job, and the job list now confirms before deleting the current selection while leaving retry and cancel unchanged. Raise modal z-index so the backdrop and panel consistently layer over the left navigation rail. This uses the app's existing dialog stack instead of adding a new UI library, keeps styling consistent, and adds focused test coverage for the single-job and bulk delete flows. Fixes #545.
bgentry
force-pushed
the
bg/delete-confirm-dialog
branch
from
fcc483d to
d7b0de5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting jobs is irreversible, but the UI previously dispatched both the single-job and bulk delete actions immediately. That made it too easy to remove the wrong jobs with one stray click, especially from the bulk selection toolbar.
This change adds a shared confirmation dialog built on the existing Headless UI
Dialogprimitives and routes only delete actions through it. The job detail page now confirms before deleting one job, and the job list now confirms before deleting the current selection while leaving retry and cancel unchanged.It also raises modal z-index so the backdrop and panel consistently layer over the left navigation rail.
This keeps behavior consistent with the app's existing dialog stack and adds focused test coverage for the single-job and bulk delete flows.
Fixes #545.