fix(android): prevent draw errors on view dispose#243
Merged
mfazekas merged 2 commits intofeat/rive-ios-experimentalfrom May 5, 2026
Merged
fix(android): prevent draw errors on view dispose#243mfazekas merged 2 commits intofeat/rive-ios-experimentalfrom
mfazekas merged 2 commits intofeat/rive-ios-experimentalfrom
Conversation
Don't close artboard/surface in dispose() — the command queue may still have a pending draw command referencing them. Just null the handles and stop the render loop. Resources are cleaned up by GC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigating away from a Rive screen produced:
The command queue processes commands in order:
close(artboard)thendraw(artboard). The draw finds the artboard already closed.Fix: don't call
.close()indispose()— just null the handles and stop the render loop. The command queue drains naturally and resources are cleaned up by GC.Test plan