workflows: drop CIBW_BUILD_VERBOSITY - #344
Merged
Merged
Conversation
luhenry
added a commit
that referenced
this pull request
Aug 25, 2026
The wheels statically link the bundled lz4 1.9.4 and xxHash 0.6.5 C sources under lz4libs/, but only ship python-lz4's own BSD-3-Clause LICENSE. Both vendored libraries are BSD-2-Clause and require their copyright notice to be reproduced in binary redistributions, so carry upstream PR #344 (refreshed onto v4.4.5) to add the two notices and declare them via license_files. Applying the patch dirties the checkout, which makes setuptools_scm derive 4.4.6.dev0 rather than the tag, so pin the version with SETUPTOOLS_SCM_PRETEND_VERSION_FOR_LZ4 and drop the now-pointless full-history fetch.
luhenry
added a commit
that referenced
this pull request
Aug 25, 2026
* lz4: add build-lz4.yml for riscv64 wheels
Port python-lz4 4.4.5 to riscv64, mirroring upstream's build_dist.yml
cibuildwheel job narrowed to manylinux_riscv64.
The wheel bundles lz4libs (PYLZ4_USE_SYSTEM_LZ4=False), so no system
liblz4 is needed in the container. Tests run upstream's tox suite, but
via `-e py --installpkg {wheel}` so the suite exercises the built wheel
rather than an editable install, and without the flake8/docs envs that
upstream's bare `tox -c {project}` also picks up.
* lz4: package licenses of vendored lz4 and xxHash sources
The wheels statically link the bundled lz4 1.9.4 and xxHash 0.6.5 C sources
under lz4libs/, but only ship python-lz4's own BSD-3-Clause LICENSE. Both
vendored libraries are BSD-2-Clause and require their copyright notice to be
reproduced in binary redistributions, so carry upstream PR #344 (refreshed
onto v4.4.5) to add the two notices and declare them via license_files.
Applying the patch dirties the checkout, which makes setuptools_scm derive
4.4.6.dev0 rather than the tag, so pin the version with
SETUPTOOLS_SCM_PRETEND_VERSION_FOR_LZ4 and drop the now-pointless full-history
fetch.
* lz4: backport upstream's SPDX license expression
v4.4.5's setup.py declares the licence only through the deprecated
`License :: OSI Approved :: BSD License` classifier, so the wheel's METADATA
carries no `License:`/`License-Expression:` field and update_doc.py renders the
package's docs entry as `license: Unknown`. Backport the upstream commit that
sets `license='BSD-3-Clause'`; the docs entry now names the licence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
CIBW_BUILD_VERBOSITYfrom the five workflows that still set it.These are the workflows new ports get mined for patterns, so leaving the setting
here means it keeps getting copied into new
build-<pkg>.ymlfiles.No functional change to what gets built.
🤖 Generated with Claude Code