Skip to content

docs: add protobuf - #293

Merged
threexc merged 2 commits into
mainfrom
github-actions/add-doc-for-protobuf
Aug 21, 2026
Merged

docs: add protobuf#293
threexc merged 2 commits into
mainfrom
github-actions/add-doc-for-protobuf

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automatically generated PR to document a newly published wheel. Please review it carefully before merging.

If necessary, force-push this branch.

@github-actions
github-actions Bot requested review from justeph and threexc August 20, 2026 18:00
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://riseproject-dev.github.io/python-wheels/pr-preview/pr-293/

Built to branch gh-pages at 2026-08-21 11:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@threexc

threexc commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

I wonder if it's worth adding a comment: in the docs about this part of the workflow:

    # Unlike upstream (which builds a large cross-compiled matrix via Bazel), we
		
    # build the riscv64 bdist from the sdist with cibuildwheel. protobuf's
		
    # setup.py compiles the bundled upb/utf8_range C sources into the
		
    # google._upb._message extension - no protoc or Bazel is needed at this
		
    # stage, and no external native dependency (so, no CIBW_BEFORE_BUILD).

Normally we reserve comments for:

  1. Patches to the source code in some way
  2. Build config/metadata changes
  3. Test skips

So I'm fine not to. What do you think @luhenry?

@luhenry

luhenry commented Aug 20, 2026

Copy link
Copy Markdown
Member

It doesn't hurt to leave a note!

Add version 7.35.1

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
@threexc
threexc force-pushed the github-actions/add-doc-for-protobuf branch from be635eb to 6bfd763 Compare August 20, 2026 19:33
@luhenry
luhenry marked this pull request as ready for review August 20, 2026 20:01
Comment thread docs/packages/protobuf.yaml Outdated
Co-authored-by: Ludovic Henry <git@ludovic.dev>
@threexc
threexc merged commit c2e6c77 into main Aug 21, 2026
5 checks passed
@threexc
threexc deleted the github-actions/add-doc-for-protobuf branch August 21, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants