Fix panic in Parquet export of MetricsViewTimeSeries#9725
Open
nishantmonu51 wants to merge 1 commit into
Open
Conversation
The time column prepended in MetricsViewTimeSeries.Export had no type, which left a nil arrow.DataType in WriteParquet's schema and panicked in array.NewRecordBuilder. Set the column type to CODE_TIMESTAMP and reject unmapped type codes with an error instead of panicking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetricsViewTimeSeries.Exportprepended the time column to the export meta without a type, soWriteParquetbuilt an arrow field with a nilarrow.DataTypeand panicked inarray.NewRecordBuilder. The column now carriesCODE_TIMESTAMP, and the timestamp value is truncated to microseconds since arrow rejects sub-microsecond strings fortimestamp[us]columns. CSV and XLSX output is unchanged.WriteParquetnow returns an error for type codes it does not map to an arrow type (previously a panic forINT256,UINT128,UINT256,JSON,POINT,POLYGON, and untyped columns).Checklist: