Fix metrics view annotation validation checking the metrics view's model/table instead of the annotation's#9724
Open
nishantmonu51 wants to merge 1 commit into
Open
Fix metrics view annotation validation checking the metrics view's model/table instead of the annotation's#9724nishantmonu51 wants to merge 1 commit into
model/table instead of the annotation's#9724nishantmonu51 wants to merge 1 commit into
Conversation
…ble instead of the annotation's The "exactly one of model/table" checks inside the annotations loop read the metrics view's top-level fields, so an annotation that set neither field passed validation silently, and annotations on parent-based derived metrics views were always rejected. Check the annotation's own fields instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model/table" checks inside the annotations loop inparse_metrics_view.goread the metrics view's top-levelmodel/tablefields instead of the annotation's own fields.parent-based derived metrics views were always rejected, since derived views cannot set a data source.annotation.model/annotation.table, and added parser tests for both error cases plus annotations on a derived metrics view.Checklist: