Open
Conversation
Removed 'unsafe-eval' from the script-src directive in web-admin/svelte.config.js. Vega charts use vega-interpreter (with ast: true, expr: expressionInterpreter) as of commit 8350025, which makes them CSP-compliant without eval. No other direct uses of eval() or new Function() were found in the codebase.
The Stripe docs' CSP guidance (adding checkout.stripe.com to script-src, connect-src, frame-src) only applies if Stripe.js or embedded Checkout is loaded directly in the page. Since this integration redirects to Stripe-hosted pages and all Stripe API calls happen server-side in Go, none of those entries are needed. If the integration ever moves to embedded Checkout, the specific entries to add would be https://js.stripe.com (script-src), https://api.stripe.com (connect-src), and https://js.stripe.com https://hooks.stripe.com (frame-src).
AdityaHegde
reviewed
Apr 24, 2026
| "https://docs.google.com", | ||
| "https://storage.googleapis.com", | ||
| "https://cdn.prod.website-files.com", | ||
| "https://*.stripe.com", |
Collaborator
There was a problem hiding this comment.
Is this intended change?
| "self", | ||
| "unsafe-eval", | ||
| "https://*.app-us1.com/", | ||
| //https://support.usepylon.com/articles/5968160735-chat-widget-debugging-guide |
Collaborator
There was a problem hiding this comment.
Lets not keep commented parts. If we want to add exception for this, uncomment it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed 'unsafe-eval' from the script-src directive in web-admin/svelte.config.js. Vega charts use vega-interpreter (with ast: true, expr: expressionInterpreter) as of commit 8350025, which makes them CSP-compliant without eval. No other direct uses of eval() or new Function() were found in the codebase.
Checklist: