fix: nav tab underline sticks to stale position after sibling tabs mount#9259
Open
fix: nav tab underline sticks to stale position after sibling tabs mount#9259
Conversation
ResizeObserver only fires on size changes, so when sibling tabs in ProjectTabs/OrganizationTabs mounted async (feature flags, permissions), the selected tab's cached offsetLeft stayed stale and the underline landed under the wrong tab. Also set position.set when the selected tab's offsetLeft is 0, and drop the $position truthiness gate in the parent templates so the first tab still shows the underline. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
AdityaHegde
reviewed
Apr 21, 2026
| } | ||
| }); | ||
| $: if (selected && size) { | ||
| width.set(size); |
Collaborator
There was a problem hiding this comment.
We need to resist how we share width and position. Using a single global feels wrong since you cant have multiple instances in that case. Out of scope of this PR
| </nav> | ||
|
|
||
| {#if $width && $position} | ||
| {#if $width} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When AI is disabled
Checklist:
Developed in collaboration with Claude Code