Skip to content

Make login button spinner more robust by using Bootstrap's data-bs-submit attribute #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatrixNeoKozak wants to merge 1 commit into from
Closed

Make login button spinner more robust by using Bootstrap's data-bs-submit attribute #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions accounts/templates/accounts/otp_login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,10 @@ <h2 class="form-signin-heading">{% trans "Sign In" %}</h2>

{% block script %}
<script>
$(document).ready(function() {
$("#btn-signin").click(function() {
// disable button
$(this).prop("disabled", true);
// add spinner to button
$(this).html(
`
<span class="spinner-border spinner-border-sm" role="status" aria-hidden="true"></span>
{% trans "Loading" %}...
`
);
$("#form-signin").submit();
});
});
document.getElementById('form-signin').addEventListener('submit', function() {
var btn = document.getElementById('btn-signin');
btn.disabled = true;
btn.innerHTML = '<span class="spinner-border spinner-border-sm" role="status" aria-hidden="true"></span> {% trans "Loading" %}...';
});
</script>
{% endblock script%}
{% endblock script %}
21 changes: 6 additions & 15 deletions accounts/templates/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,10 @@ <h2 class="form-signin-heading">{% trans "Sign In" %}</h2>

{% block script %}
<script>
$(document).ready(function() {
$("#btn-signin").click(function() {
// disable button
$(this).prop("disabled", true);
// add spinner to button
$(this).html(
`
<span class="spinner-border spinner-border-sm" role="status" aria-hidden="true"></span>
{% trans "Loading" %}...
`
);
$("#form-signin").submit();
});
});
document.getElementById('form-signin').addEventListener('submit', function() {
var btn = document.getElementById('btn-signin');
btn.disabled = true;
btn.innerHTML = '<span class="spinner-border spinner-border-sm" role="status" aria-hidden="true"></span> {% trans "Loading" %}...';
});
</script>
{% endblock script%}
{% endblock script %}