feat: remove contact import onError option#982
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
commit: |
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Removes an unsupported onError option from contact import creation. Changes are minimal, isolated, and align the SDK with the API.
Re-trigger cubic
dielduarte
approved these changes
Jun 15, 2026
lucasfcosta
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onErrorfromCreateContactImportOptions.on_errorin contact import create form data.Test plan
pnpm vitest run src/contacts/imports/contact-imports.spec.ts --exclude e2epnpm run typecheck(fails: existing TypeScript 6 deprecation formoduleResolution=node10intsconfig.json)Made with Cursor
Summary by cubic
Removed the
onErroroption from contact import creation and stopped sendingon_errorin the form payload. Aligns the SDK with the API and removes an unsupported parameter.onErrorusage fromCreateContactImportOptions(and relatedContactImportOnErrortypes).onConflict,segments, andtopicsare unchanged.Written for commit 306399a. Summary will update on new commits.