Skip to content

feat: remove contact import onError option#982

Merged
vcapretz merged 1 commit into
canaryfrom
remove-contact-import-on-error
Jun 15, 2026
Merged

feat: remove contact import onError option#982
vcapretz merged 1 commit into
canaryfrom
remove-contact-import-on-error

Conversation

@vcapretz

@vcapretz vcapretz commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove onError from CreateContactImportOptions.
  • Stop sending on_error in contact import create form data.
  • Update contact import create test coverage for the new request payload.

Test plan

  • pnpm vitest run src/contacts/imports/contact-imports.spec.ts --exclude e2e
  • pnpm run typecheck (fails: existing TypeScript 6 deprecation for moduleResolution=node10 in tsconfig.json)

Made with Cursor


Summary by cubic

Removed the onError option from contact import creation and stopped sending on_error in the form payload. Aligns the SDK with the API and removes an unsupported parameter.

  • Migration
    • Remove any onError usage from CreateContactImportOptions (and related ContactImportOnError types).
    • No replacement; server default error handling is used.
    • onConflict, segments, and topics are unchanged.

Written for commit 306399a. Summary will update on new commits.

Review in cubic

Co-authored-by: Cursor <cursoragent@cursor.com>
@vcapretz vcapretz requested a review from a team as a code owner June 15, 2026 16:02
@vcapretz vcapretz requested a review from dielduarte June 15, 2026 16:02
@pkg-pr-new

pkg-pr-new Bot commented Jun 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/resend@982

commit: 306399a

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Removes an unsupported onError option from contact import creation. Changes are minimal, isolated, and align the SDK with the API.

Re-trigger cubic

@vcapretz vcapretz changed the title Remove contact import onError option feat: remove contact import onError option Jun 15, 2026
@vcapretz vcapretz self-assigned this Jun 15, 2026
@vcapretz vcapretz merged commit cb3d1d1 into canary Jun 15, 2026
13 of 15 checks passed
@vcapretz vcapretz deleted the remove-contact-import-on-error branch June 15, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants