Skip to content

Remove deprecated %external extension #8376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cknitt wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −24
Open

Remove deprecated %external extension #8376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8345e58
Remove deprecated %external extension
cknitt Apr 20, 2026
20806f6
CHANGELOG
cknitt Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

- Support for `break` and `continue` in loops. `break` and `continue` are new keywords. https://github.com/rescript-lang/rescript/pull/8348
- Fix iterator / iterable typedefs, add generator typedefs. https://github.com/rescript-lang/rescript/pull/8355
- Remove deprecated %external extension. https://github.com/rescript-lang/rescript/pull/8376

#### :eyeglasses: Spec Compliance

Expand Down
7 changes: 0 additions & 7 deletions compiler/frontend/ast_exp_extension.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,6 @@ let handle_extension e (self : Bs_ast_mapper.mapper)
Exp.constraint_ ~loc
(Ast_exp_handle_external.handle_raw ~kind:Raw_re loc payload)
(Ast_comb.to_regexp_type loc)
| "external" -> (
Location.deprecated loc
"%external is deprecated, use %raw or regular FFI syntax instead.";
match Ast_payload.as_ident payload with
| Some {txt = Lident x} -> Ast_exp_handle_external.handle_external loc x
| None | Some _ ->
Location.raise_errorf ~loc "external expects a single identifier")
| "debugger" ->
{e with pexp_desc = Ast_exp_handle_external.handle_debugger loc payload}
| "obj" -> (
Expand Down
13 changes: 0 additions & 13 deletions tests/tests/src/ExternalExtension.mjs
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tests/tests/src/ExternalExtension.res
View file
Open in desktop

This file was deleted.

Loading