-
-
Notifications
You must be signed in to change notification settings - Fork 257
chore(deps): bump react-router from 7.15.0 to 8.3.0 #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2425,7 +2425,7 @@ __metadata: | |
| react: "npm:^19.2.4" | ||
| react-dom: "npm:^19.2.4" | ||
| react-markdown: "npm:^10.1.0" | ||
| react-router: "npm:^7.15.0" | ||
| react-router: "npm:^8.3.0" | ||
| react-router-dom: "npm:^7.15.0" | ||
| rehype-slug: "npm:^6.0.0" | ||
| rehype-stringify: "npm:^10.0.1" | ||
|
|
@@ -2474,7 +2474,7 @@ __metadata: | |
| react: "npm:^19.2.4" | ||
| react-dom: "npm:^19.2.4" | ||
| react-markdown: "npm:^10.1.0" | ||
| react-router: "npm:^7.15.0" | ||
| react-router: "npm:^8.3.0" | ||
| react-router-dom: "npm:^7.15.0" | ||
| remark-comment: "npm:^1.0.0" | ||
| remark-frontmatter: "npm:^5.0.0" | ||
|
|
@@ -2502,7 +2502,7 @@ __metadata: | |
| lz-string: "npm:^1.5.0" | ||
| react: "npm:^19.2.4" | ||
| react-dom: "npm:^19.2.4" | ||
| react-router: "npm:^7.15.0" | ||
| react-router: "npm:^8.3.0" | ||
| languageName: unknown | ||
| linkType: soft | ||
|
|
||
|
|
@@ -4405,6 +4405,13 @@ __metadata: | |
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "cookie-es@npm:^3.1.1": | ||
| version: 3.1.1 | ||
| resolution: "cookie-es@npm:3.1.1" | ||
| checksum: 10c0/62cf0c325cc547b52477b351e9b5d068b3ffc74f7d143cdf7af854648dd1015fca3aed1498b355365e24b0746333f0b15688ed3a535abecc5ed0a046ae956a84 | ||
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "cookie-signature@npm:1.0.6": | ||
| version: 1.0.6 | ||
| resolution: "cookie-signature@npm:1.0.6" | ||
|
|
@@ -9475,7 +9482,7 @@ __metadata: | |
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "react-router@npm:7.15.0, react-router@npm:^7.15.0": | ||
| "react-router@npm:7.15.0": | ||
| version: 7.15.0 | ||
| resolution: "react-router@npm:7.15.0" | ||
| dependencies: | ||
|
|
@@ -9491,6 +9498,21 @@ __metadata: | |
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "react-router@npm:^8.3.0": | ||
| version: 8.3.0 | ||
| resolution: "react-router@npm:8.3.0" | ||
| dependencies: | ||
| cookie-es: "npm:^3.1.1" | ||
| peerDependencies: | ||
| react: ">=19.2.7" | ||
| react-dom: ">=19.2.7" | ||
|
Comment on lines
+9507
to
+9508
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
With immutable installs, the lockfile still resolves both React packages to 19.2.4, but the newly selected Router 8.3.0 declares Useful? React with 👍 / 👎. |
||
| peerDependenciesMeta: | ||
| react-dom: | ||
| optional: true | ||
| checksum: 10c0/c1277d6a75ff1b77e759bc0142e3257b6cea1eb683595a64a19d7fb341a7b9ba30c81ef8fc426e437c7fbec043bde683462b2463a055b0f58c8e5ad19cdee2ad | ||
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "react@npm:^19.2.4": | ||
| version: 19.2.4 | ||
| resolution: "react@npm:19.2.4" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When either site runs
react-router buildor the dev server,@react-router/devand@react-router/noderemain on 7.15.0 and requirereact-router7.x (the latter requires exactly 7.15.0), while route modules now import 8.3.0; Yarn confirms this unsupported combination with YN0060 peer errors for both the docs and guide workspaces. Keep the core package on v7 or upgrade all framework packages, includingreact-router-dom, to compatible versions together.AGENTS.md reference: AGENTS.md:L101-L101
Useful? React with 👍 / 👎.