docs: note pnpm hoisting caveat for @rescript/runtime#1254
Open
JonoPrest wants to merge 1 commit intorescript-lang:masterfrom
Open
docs: note pnpm hoisting caveat for @rescript/runtime#1254JonoPrest wants to merge 1 commit intorescript-lang:masterfrom
JonoPrest wants to merge 1 commit intorescript-lang:masterfrom
Conversation
pnpm's strict isolation does not expose transitive dependencies at the app root, so ReScript-compiled JS importing @rescript/runtime fails to resolve. Add a callout to the installation and v12 migration docs explaining the two workarounds (direct install or publicHoistPattern in pnpm-workspace.yaml) and fix a small typo while at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm's strict isolation does not expose transitive dependencies at the app root, so ReScript-compiled JS importing @rescript/runtime fails to resolve. Add a callout to the installation and v12 migration docs explaining the two workarounds (direct install or publicHoistPattern in pnpm-workspace.yaml) and fix a small typo while at it.
Related issue: rescript-lang/rescript#8357