Skip to content

refactor: migrate from primeng to optimus-ui - #9

Merged
Garfield-fr merged 1 commit into
rero:mainfrom
Garfield-fr:optimus-ui-migration
Aug 6, 2026
Merged

refactor: migrate from primeng to optimus-ui#9
Garfield-fr merged 1 commit into
rero:mainfrom
Garfield-fr:optimus-ui-migration

Conversation

@Garfield-fr

Copy link
Copy Markdown
Collaborator
  • Replace primeng, primeicons and tailwindcss-primeui with @openng/optimus-ui, @openng/icons, @openng/optimus-ui-themes and @openng/optimus-ui-tailwindcss
  • Update imports and provider calls across app config, toast, paginator, interceptor and feature components
  • Switch package manager artifacts from npm to pnpm
  • Bump Angular, ngrx/signals, tailwindcss, vitest and other dependencies within their existing semver ranges

@Garfield-fr Garfield-fr self-assigned this Aug 6, 2026
@Garfield-fr
Garfield-fr force-pushed the optimus-ui-migration branch from 1d957b2 to 021d71a Compare August 6, 2026 12:16
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The project upgraded Angular, NgRx, TypeScript, Vitest, Tailwind, RxJS, and related dependencies. It added OpenNG Optimus UI packages and build-script allowlisting. PrimeNG providers, components, services, icons, themes, and Tailwind integration were replaced with Optimus UI equivalents. TypeScript root directories and path aliases were updated.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: migrating from PrimeNG to Optimus UI.
Description check ✅ Passed The description accurately covers the UI migration, import updates, package manager changes, and dependency upgrades.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/app/app.config.ts`:
- Line 4: Update the Aura import in app.config.ts to use the lowercase
`@openng/optimus-ui-themes/aura` subpath, preserving the existing Aura symbol
usage.

In `@src/styles.scss`:
- Line 3: Update the Stylelint configuration for the scss/at-rule-no-unknown
rule to recognize the `@plugin` directive used by the stylesheet, using the
narrowest available exception without weakening validation for other unknown
at-rules.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 42aaf9fc-bf4e-439a-a26b-0ea08870ad8b

📥 Commits

Reviewing files that changed from the base of the PR and between 73cf610 and 1d957b2.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (17)
  • package.json
  • pnpm-workspace.yaml
  • src/app/app.config.mock.ts
  • src/app/app.config.ts
  • src/app/app.ts
  • src/app/features/books/search.ts
  • src/app/features/login/login.ts
  • src/app/features/sidebar/sidebar.ts
  • src/app/features/todo/store/todo.store.ts
  • src/app/features/todo/todo.ts
  • src/app/shared/component/paginator.ts
  • src/app/shared/interceptor/http-response-error-interceptor.ts
  • src/app/shared/store/paginator-feature.ts
  • src/styles.scss
  • tsconfig.app.json
  • tsconfig.json
  • tsconfig.spec.json

Comment thread src/app/app.config.ts Outdated
Comment thread src/styles.scss
@Garfield-fr
Garfield-fr force-pushed the optimus-ui-migration branch 2 times, most recently from 5fe318a to 8171355 Compare August 6, 2026 12:34
* Replace primeng, primeicons and tailwindcss-primeui with
  @openng/optimus-ui, @openng/icons, @openng/optimus-ui-themes
  and @openng/optimus-ui-tailwindcss
* Update imports and provider calls across app config,
  toast, paginator, interceptor and feature components
* Switch package manager artifacts from npm to pnpm
* Update CI workflow to install and test with pnpm
* Bump Angular, ngrx/signals, tailwindcss, vitest and other
  dependencies within their existing semver ranges

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr
Garfield-fr force-pushed the optimus-ui-migration branch from 8171355 to 71025d2 Compare August 6, 2026 12:36
@Garfield-fr
Garfield-fr merged commit 89d6ca8 into rero:main Aug 6, 2026
3 checks passed
@Garfield-fr
Garfield-fr deleted the optimus-ui-migration branch August 6, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant